-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTA-543: remove prometheus rule and add query directly to scaledObject #973
base: master
Are you sure you want to change the base?
Conversation
@PratikMahajan: This pull request references OTA-543 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PratikMahajan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
we added prometheusrule as we were not able to use complex queries in HPA. But with scaledObject we can directly use complex queries for scaling replicas and dont need prometheusrule anymore.
69618d9
to
f3abb60
Compare
@PratikMahajan: This pull request references OTA-543 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test ci/prow/customrust-e2e |
@PratikMahajan: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test customrust-e2e |
/retest |
@PratikMahajan: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
we added prometheusrule as we were not able to use complex
queries in HPA.
But with scaledObject we can directly use complex queries
for scaling replicas and dont need prometheusrule anymore.