Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA-543: remove prometheus rule and add query directly to scaledObject #973

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PratikMahajan
Copy link
Contributor

@PratikMahajan PratikMahajan commented Oct 24, 2024

we added prometheusrule as we were not able to use complex
queries in HPA.
But with scaledObject we can directly use complex queries
for scaling replicas and dont need prometheusrule anymore.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 24, 2024

@PratikMahajan: This pull request references OTA-543 which is a valid jira issue.

In response to this:

remove cincinnati-recording-rule and directly use query in scaledObject

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from petr-muller and wking October 24, 2024 19:20
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PratikMahajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
we added prometheusrule as we were not able to use complex
queries in HPA.
But with scaledObject we can directly use complex queries
for scaling replicas and dont need prometheusrule anymore.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 24, 2024

@PratikMahajan: This pull request references OTA-543 which is a valid jira issue.

In response to this:

we added prometheusrule as we were not able to use complex
queries in HPA.
But with scaledObject we can directly use complex queries
for scaling replicas and dont need prometheusrule anymore.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PratikMahajan
Copy link
Contributor Author

/test ci/prow/customrust-e2e

Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

@PratikMahajan: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test cargo-test
  • /test customrust-cargo-test
  • /test customrust-e2e
  • /test customrust-images
  • /test customrust-rustfmt-1.64.0
  • /test customrust-rustfmt-1.70.0
  • /test customrust-yaml-lint
  • /test e2e
  • /test images
  • /test rustfmt-1.64.0
  • /test rustfmt-1.70.0
  • /test yaml-lint

Use /test all to run all jobs.

In response to this:

/test ci/prow/customrust-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@PratikMahajan
Copy link
Contributor Author

/test customrust-e2e

@PratikMahajan
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

@PratikMahajan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/cargo-test f3abb60 link true /test cargo-test
ci/prow/customrust-cargo-test f3abb60 link true /test customrust-cargo-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants