Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTA-15: Return 400 Bad Request for responses that contain an empty graph #933

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

OTA-15: Return 400 Bad Request for responses that contain an empty graph #933

wants to merge 1 commit into from

Conversation

DavidHurta
Copy link
Contributor

@DavidHurta DavidHurta commented Aug 29, 2024 •
edited
Loading

Return 400 Bad Request for responses that contain an empty graph. Such
responses are currently only generated when a specified channel and
architecture result in an empty update graph due to the filtering.

This commit is part of the effort to improve the UX regarding requests
that contain invalid query parameters. In the future, more fine-grained
return messages will be returned.

This pull request references https://issues.redhat.com/browse/OTA-15

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@DavidHurta
Copy link
Contributor Author

/test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Davoska
Once this PR has been reviewed and has the lgtm label, please assign wking for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DavidHurta DavidHurta force-pushed the return-error-for-empty-graph branch from 91dced7 to 7576bce Compare August 30, 2024 09:09
@DavidHurta
Copy link
Contributor Author

/test all

@DavidHurta
Return 400 Bad Request for responses that contain empty graph
0d7d4ba 
Return `400 Bad Request` for responses that contain an empty graph. Such
responses are currently only generated when a specified channel and
architecture result in an empty update graph due to the filtering.

This commit is part of the effort to improve the UX regarding requests
that contain invalid query parameters. In the future, more fine-grained
return messages will be returned.
@DavidHurta DavidHurta force-pushed the return-error-for-empty-graph branch from 7576bce to 0d7d4ba Compare August 30, 2024 12:00
@DavidHurta
Copy link
Contributor Author

/test all

@DavidHurta DavidHurta force-pushed the return-error-for-empty-graph branch from 7acebf7 to 6152c3e Compare August 30, 2024 12:51
@DavidHurta
Copy link
Contributor Author

/test ci/prow/cargo-test

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

@Davoska: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test cargo-test
  • /test customrust-cargo-test
  • /test customrust-e2e
  • /test customrust-images
  • /test customrust-rustfmt-1.64.0
  • /test customrust-rustfmt-1.70.0
  • /test customrust-yaml-lint
  • /test e2e
  • /test images
  • /test rustfmt-1.64.0
  • /test rustfmt-1.70.0
  • /test yaml-lint

Use /test all to run all jobs.

In response to this:

/test ci/prow/cargo-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@DavidHurta
Copy link
Contributor Author

/test cargo-test

1 similar comment
@DavidHurta
Copy link
Contributor Author

/test cargo-test

@DavidHurta DavidHurta force-pushed the return-error-for-empty-graph branch from e528b17 to d571b89 Compare August 30, 2024 13:38
@DavidHurta
Copy link
Contributor Author

/test cargo-test

1 similar comment
@DavidHurta
Copy link
Contributor Author

/test cargo-test

@DavidHurta DavidHurta force-pushed the return-error-for-empty-graph branch from 87afb23 to 0d7d4ba Compare September 2, 2024 10:27
@DavidHurta DavidHurta changed the title WIP WIP: Return 400 Bad Request for responses that contain an empty graph Sep 2, 2024
@DavidHurta DavidHurta changed the title WIP: Return 400 Bad Request for responses that contain an empty graph OTA-15: WIP: Return 400 Bad Request for responses that contain an empty graph Sep 2, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2024 •
edited by openshift-ci bot
Loading

@Davoska: This pull request references OTA-15 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 2, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2024 •
edited by openshift-ci bot
Loading

@Davoska: This pull request references OTA-15 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Return 400 Bad Request for responses that contain an empty graph. Such
responses are currently only generated when a specified channel and
architecture result in an empty update graph due to the filtering.

This commit is part of the effort to improve the UX regarding requests
that contain invalid query parameters. In the future, more fine-grained
return messages will be returned.

This pull request references https://issues.redhat.com/browse/OTA-15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidHurta DavidHurta changed the title OTA-15: WIP: Return 400 Bad Request for responses that contain an empty graph OTA-15: Return 400 Bad Request for responses that contain an empty graph Sep 2, 2024
@DavidHurta
Copy link
Contributor Author

/test all

1 similar comment
@DavidHurta
Copy link
Contributor Author

/test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

@Davoska: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/customrust-cargo-test 0d7d4ba link true /test customrust-cargo-test
ci/prow/e2e 0d7d4ba link true /test e2e
ci/prow/cargo-test 0d7d4ba link true /test cargo-test
ci/prow/customrust-e2e 0d7d4ba link true /test customrust-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 6, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidHurta @openshift-ci-robot @openshift-bot