Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLAT-1743: Add VMGroup to VSphere Provider workspace #2074

Merged
merged 1 commit into from
Nov 26, 2024
Merged

SPLAT-1743: Add VMGroup to VSphere Provider workspace #2074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions machine/v1beta1/types_vsphereprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,10 @@ type Workspace struct {
// ResourcePool is the resource pool in which VMs are created/located.
// +optional
ResourcePool string `gcfg:"resourcepool-path,omitempty" json:"resourcePool,omitempty"`
// vmGroup is the cluster vm group in which virtual machines will be added for vm host group based zonal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the failure domains API, we limit this field to 80 characters IIRC, is that also being implemented in the MAPI validation webhook?

// +openshift:validation:featureGate=VSphereHostVMGroupZonal
// +optional
VMGroup string `gcfg:"vmGroup,omitempty" json:"vmGroup,omitempty"`
jcpowermac marked this conversation as resolved.
Show resolved Hide resolved
}

// VSphereMachineProviderStatus is the type that will be embedded in a Machine.Status.ProviderStatus field.
Expand Down
1 change: 1 addition & 0 deletions machine/v1beta1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions openapi/generated_openapi/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions openapi/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22430,6 +22430,10 @@
"server": {
"description": "Server is the IP address or FQDN of the vSphere endpoint.",
"type": "string"
},
"vmGroup": {
"description": "vmGroup is the cluster vm group in which virtual machines will be added for vm host group based zonal.",
"type": "string"
}
}
},
Expand Down