Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Feature Gate for Bootc Update Path #1969

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Added Feature Gate for Bootc Update Path #1969

merged 1 commit into from
Jul 23, 2024

Conversation

inesqyx
Copy link
Contributor

@inesqyx inesqyx commented Jul 22, 2024

This is for openshift/enhancements#1631
The MCO is experimenting a bootc based OS content update path, to prepare for the deprecation of rpm-ostree. Before bootc is fully ready, we need to gate the path from default mainly for testing purposes.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

Hello @inesqyx! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 22, 2024
@openshift-ci openshift-ci bot requested review from deads2k and knobunc July 22, 2024 20:43
@inesqyx
Copy link
Contributor Author

inesqyx commented Jul 22, 2024

/retest-required

@inesqyx
Copy link
Contributor Author

inesqyx commented Jul 23, 2024

/test verify

1 similar comment
@inesqyx
Copy link
Contributor Author

inesqyx commented Jul 23, 2024

/test verify

deads2k
deads2k reviewed Jul 23, 2024
View reviewed changes
features/features.go Outdated
@@ -348,6 +348,13 @@ var (
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()

FeatureGateBootcUpdatePath = newFeatureGate("BootcUpdatePath").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why specific for updates?

@deads2k
Copy link
Contributor

deads2k commented Jul 23, 2024

/assign @yuqi-zhang

@inesqyx inesqyx force-pushed the featuregate-bootc branch from f0b0545 to 25db57e Compare July 23, 2024 14:37
@deads2k
Copy link
Contributor

deads2k commented Jul 23, 2024

/approve

verify is still broken.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@inesqyx inesqyx force-pushed the featuregate-bootc branch 2 times, most recently from 395679b to 2171c31 Compare July 23, 2024 15:35
@inesqyx inesqyx force-pushed the featuregate-bootc branch from 2171c31 to d96a9f2 Compare July 23, 2024 15:39
@inesqyx
Copy link
Contributor Author

inesqyx commented Jul 23, 2024

/test e2e-aws-ovn-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

@inesqyx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp d96a9f2 link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yuqi-zhang
Copy link
Contributor

/lgtm

Just noting that this will likely not be customer facing for the next release or two, but safe to have for internal testing and CI

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, inesqyx, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 442f06d into openshift:master Jul 23, 2024
17 of 18 checks passed
@inesqyx inesqyx mentioned this pull request Jul 24, 2024
Merged
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202407240243.p0.g442f06d.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@yuqi-zhang yuqi-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@inesqyx @deads2k @yuqi-zhang @openshift-bot