#2550 Allowing joins when index names start with a period #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…period. Signed-off-by: Jeff <[email protected]>
jzonthemtn
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224 and
LantaoJin
as code owners
LantaoJin
reviewed
Aug 29, 2024
|
|
||
| assertThat( | ||
| "identifier1.identifier2", equalTo(unquoteFullColumn("`identifier1`.`identifier2`"))); | ||
| assertThat("identifier1.identifier2", equalTo(unquoteFullColumn("`identifier1`.identifier2"))); | ||
| assertThat( | ||
| ".identifier1.identifier2", equalTo(unquoteFullColumn("`.identifier1`.`identifier2`"))); |
There was a problem hiding this comment.
Does the queries (without join) work before this fixing?
select q.query_id
from .ubi_log_queries q
select q.query_id
from `.ubi_log_queries` qCould you add some tests to verify the objective issue is fixed:
select q.query_id
from .ubi_log_queries q join .ubi_log_events e
on q.query_id = e.query_id
select q.query_id
from `.ubi_log_queries` q join `.ubi_log_events` e
on q.query_id = e.query_idThere was a problem hiding this comment.
Yes, those queries work fine.
I'm open to testing suggestions, but the issue is the presence of the period inside the backticks. When an index starts with a ., the period is not included in the backticks.
dai-chen
reviewed
Aug 29, 2024
| if (text.startsWith(quote + ".")) { | ||
| startsWithPeriod = true; | ||
| text = quote + text.substring(2); | ||
| } | ||
| String[] strs = text.split("\\."); |
There was a problem hiding this comment.
Just wonder if any easier way to do this. Essentially, we just want to split from the second dot if text starts with . or `. ?
|
This PR is stalled because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows for join operations on indexes whose names start with periods.
Related Issues
Resolves #2550
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.