Function str_to_date should work with two-digits year
#2841
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
changed the title
str_to_date should work with two-digits year
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG and
ykmr1224
as code owners
LantaoJin
commented
Jul 18, 2024
| @@ -173,7 +173,7 @@ interface DateTimeFormatHandler { | |||
| .put("%T", "HH:mm:ss") // %T => HH:mm:ss | |||
| .put("%W", "EEEE") // %W => EEEE - Weekday name (Sunday..Saturday) | |||
| .put("%Y", "u") // %Y => yyyy - Year, numeric, 4 digits | |||
| .put("%y", "u") // %y => yy - Year, numeric, 2 digits | |||
| .put("%y", "uu") // %y => yy - Year, numeric, 2 digits | |||
There was a problem hiding this comment.
This change fixes the issue because the code:
https://github.com/openjdk/jdk/blob/35df48e1b321d16f44ba924065143af67143cf95/src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java#L2063-L2069
|
This PR is stalled because it has been open for 30 days with no activity. |
|
@LantaoJin @dai-chen is this still relevant ? |
YANG-DB
approved these changes
Dec 29, 2024
I think the issue is still existing. let me update to latest code base. |
|
CI failure not related. Merging |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2841-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4224f318871d4bf8cb35764fb7f589530449a0de
# Push it to GitHub
git push --set-upstream origin backport/backport-2841-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.xThen, create a pull request where the |
LantaoJin
added a commit
to LantaoJin/search-plugins-sql
that referenced
this pull request
Dec 30, 2024
…ject#2841) Signed-off-by: Lantao Jin <[email protected]> (cherry picked from commit 4224f31)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
str_to_datefunction in https://opensearch.org/docs/latest/search-plugins/sql/functions/#date-and-time does not work with two-digits year (RFC 822 date-time formatted).SELECT str_to_date('23-Oct-17', '%d-%b-%y')returns0017-10-23With patching, above query returns
2017-10-23.Issues Resolved
Resolves #2741
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.