Check if root cause exists in $error['error'] #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wblessen
requested review from
VachaShah,
dblock,
harshavamsi and
shyim
as code owners
shyim
requested changes
Nov 17, 2022
Yes, I can try. Do you have a draft and a suggestion, which folder to use? |
|
Hey @wblessen , sorry for the late response. You can add the test case to the existing file: https://github.com/opensearch-project/opensearch-php/blob/main/tests/Connections/ConnectionTest.php Also don't forget to sign your commits with |
|
I created my own PR #168 for this, since there doesn’t seem to be any movement on this one. |
|
Merged via #168. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opensearch failed with missing array key root_cause in Connection.php
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.