Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that S3Uri are human readable when printed #1205

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

peternied
Copy link
Member

@peternied peternied commented Dec 17, 2024

Description

When running metadata command part of the output shows the S3 uri and it was not human readable.

Example updated output

S3Uri(bucketName=bucket-name, key=, uri=s3://bucket-name)
S3Uri(bucketName=bucket-name, key=, uri=s3://bucket-name)
S3Uri(bucketName=bucket-name, key=with/suffix, uri=s3://bucket-name/with/suffix)
S3Uri(bucketName=bucket-name, key=with/suffix, uri=s3://bucket-name/with/suffix)

Example error case

Starting Metadata Evaluation
Clusters:
   Source:
      Snapshot: ELASTICSEARCH 7.10.0 S3Repo(s3RepoUri=org.opensearch.migrations.bulkload.common.S3Uri@639cb788)

Issues Resolved

N/A

Testing

N/A Simple UX change

Check List

  • New functionality includes testing
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (3d6b0ad) to head (7c90b41).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1205      +/-   ##
============================================
- Coverage     80.64%   80.63%   -0.01%     
  Complexity     3076     3076              
============================================
  Files           421      421              
  Lines         15610    15611       +1     
  Branches       1053     1053              
============================================
  Hits          12588    12588              
- Misses         2381     2382       +1     
  Partials        641      641              
Flag Coverage Δ
unittests 80.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit d1cf844 into opensearch-project:main Dec 18, 2024
22 checks passed
@peternied peternied deleted the fix-no-url branch December 18, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants