-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding subshard work items on lease expiry #1198
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
This reverts commit b055711 Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
10acac7
to
4ee028b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1198 +/- ##
============================================
- Coverage 80.52% 80.30% -0.23%
- Complexity 3072 3101 +29
============================================
Files 421 423 +2
Lines 15629 15850 +221
Branches 1057 1072 +15
============================================
+ Hits 12585 12728 +143
- Misses 2396 2474 +78
Partials 648 648
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andre Kurait <[email protected]>
…ltaneous test runs Signed-off-by: Andre Kurait <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the holidays coming up - lets hold off on merging this until after we've got a fuller crew in house.
Signed-off-by: Andre Kurait <[email protected]>
c7a5ff7
to
3c08845
Compare
Signed-off-by: Andre Kurait <[email protected]>
* We need to ensure a stable ordering of segments so we can start reading from a specific segment and document id. | ||
* To do this, we sort the segments by their ID or name. | ||
*/ | ||
static class SegmentNameSorter implements Comparator<LeafReader> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndreKurait do we still use sorting based on segment name?
Description
Continuation on #1160
Changes since #1160
Behavior changes is as follows:
The lease time increase logic has changed. Behavior is as follows:
Added E2E test as follows:
Issues Resolved
Testing
Tested in AWS and added new E2E test around the scenario
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.