Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] ByField Rerank Improvements #1117

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[Backport 2.x] ByField Rerank Improvements #1117

merged 1 commit into from
Jan 17, 2025
+143 −12

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7e01c5e from #969

@brianf-aws @github-actions
ByField Rerank Improvements (#969)
c78c69d 
* fix: better exception message

Signed-off-by: Brian Flores <[email protected]>
(cherry picked from commit 7e01c5e)
@junqiu-lei
Copy link
Member

CI failed with:

> Task :spotlessJava FAILED
815:36: error: unclosed string literal
com.google.googlejavaformat.java.FormatterException: 815:36: error: unclosed string literal
	at com.google.googlejavaformat.java.FormatterException.fromJavacDiagnostics(FormatterException.java:[51](https://github.com/opensearch-project/neural-search/actions/runs/12813078187/job/35726301876?pr=1117#step:6:52))

@junqiu-lei
Copy link
Member

junqiu-lei commented Jan 17, 2025 •
edited
Loading

@brianf-aws could you check the CI failure before merging to 2.x?

@martin-gaievski martin-gaievski merged commit d060c51 into 2.x Jan 17, 2025
56 of 69 checks passed
@brianf-aws
Copy link
Contributor

Hey @junqiu-lei Yes let me place a PR to solve this its because I was using the string block feature (Ill have to update it to use string literals) which is not supported in this branch let me fix

@brianf-aws brianf-aws mentioned this pull request Jan 17, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-gaievski martin-gaievski martin-gaievski approved these changes

@junqiu-lei junqiu-lei junqiu-lei approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@vibrantvarun vibrantvarun Awaiting requested review from vibrantvarun vibrantvarun is a code owner

@zhichao-aws zhichao-aws Awaiting requested review from zhichao-aws zhichao-aws is a code owner

@yuye-aws yuye-aws Awaiting requested review from yuye-aws yuye-aws is a code owner

@minalsha minalsha Awaiting requested review from minalsha minalsha is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junqiu-lei @brianf-aws @martin-gaievski