-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change lower bound of Pagination depth from 0 to 1 #1116
Closed
vibrantvarun
wants to merge
1
commit into
opensearch-project:main
from
vibrantvarun:rename_lower_bound
Closed
Change lower bound of Pagination depth from 0 to 1 #1116
vibrantvarun
wants to merge
1
commit into
opensearch-project:main
from
vibrantvarun:rename_lower_bound
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Jain <[email protected]>
vibrantvarun
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
zhichao-aws,
yuye-aws and
minalsha
as code owners
January 16, 2025 01:15
@vibrantvarun Can you explain the intuition behind this PR? |
vibrantvarun
changed the title
Change lower bound of Pagination depth from 1 to 0
Change lower bound of Pagination depth from 0 to 1
Jan 16, 2025
@yuye-aws by mistake I added the lower bound as 0 but it should be 1 for pagination_depth. |
yuye-aws
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Do not merge the PR now as one test case is failing |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change lower bound of Pagination depth from 0 to 1
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.