Added runtime dependencies for jackson lib #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
added
backport 2.x
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
fix_runtime_jackson_dependency
branch
from
25eda56 to
245856c
Compare
vibrantvarun
approved these changes
Jan 3, 2025
pyek-bot
approved these changes
Jan 3, 2025
heemin32
approved these changes
Jan 3, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit f844a78)
heemin32
pushed a commit
that referenced
this pull request
Jan 3, 2025
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit f844a78) Co-authored-by: Martin Gaievski <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1055-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f844a78c045116457dc75042dca1a6af410f2df3
# Push it to GitHub
git push --set-upstream origin backport/backport-1055-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed runtime exception due to mismatch of the jackson versions between neural and ml-commons. Adding runtime dependency for the library version that is defined in core OpenSearch.
Related Issues
opensearch-project/ml-commons#3321
Check List
[ ] New functionality includes testing.[ ] New functionality has been documented.[ ] API changes companion pull request created.--signoff.[ ] Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.