Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix bug where ingestion failed for input document containing list of nested objects #1053

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 90df6c9 from #1040

…nested objects (#1040)

* Fix bug where ingestion failed for input document containing list of nested objects

Signed-off-by: Yizhe Liu <[email protected]>

* Address comments to use better method name/implementation

Signed-off-by: Yizhe Liu <[email protected]>

* Address comments: modify the test case to have doc with various fields

Signed-off-by: Yizhe Liu <[email protected]>

---------

Signed-off-by: Yizhe Liu <[email protected]>
(cherry picked from commit 90df6c9)
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.69%. Comparing base (eb6121c) to head (55641e0).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...rch/neuralsearch/processor/InferenceProcessor.java 90.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1053      +/-   ##
============================================
+ Coverage     79.59%   79.69%   +0.09%     
- Complexity     1091     1106      +15     
============================================
  Files            87       87              
  Lines          3764     3802      +38     
  Branches        644      649       +5     
============================================
+ Hits           2996     3030      +34     
- Misses          522      523       +1     
- Partials        246      249       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-gaievski martin-gaievski merged commit a9c408e into 2.x Jan 3, 2025
116 of 153 checks passed
heemin32 pushed a commit to heemin32/neural-search that referenced this pull request Jan 9, 2025
…nested objects (opensearch-project#1040) (opensearch-project#1053)

* Fix bug where ingestion failed for input document containing list of nested objects

Signed-off-by: Yizhe Liu <[email protected]>
(cherry picked from commit 90df6c9)

Co-authored-by: Yizhe Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants