[backport 2.16] Fix remote model with embedding input issue #3289 #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: b4sjoo <[email protected]>
* Fix remote model with embedding input issue Signed-off-by: b4sjoo <[email protected]> * Add UT Signed-off-by: b4sjoo <[email protected]> * Spotless Signed-off-by: b4sjoo <[email protected]> * Add UT for both embedding and remote cases for all remote embedding schema Signed-off-by: b4sjoo <[email protected]> * Remove hardcoded test schema Signed-off-by: b4sjoo <[email protected]> --------- Signed-off-by: b4sjoo <[email protected]>
b4sjoo
requested review from
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
|
wondering why you didn't use the backport label at PR #2852? |
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
approved these changes
Jan 2, 2025
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #2852 & #3289
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.