Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignore decorator for testCohereClassifyModel #3324

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Jan 2, 2025

Description

Test several time on 2.x and 2.13 (the latest branch with this test), seems not flaky. Will add it back and see if we need a fix in the future.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mingshl
Copy link
Collaborator

mingshl commented Jan 2, 2025

failed tests on windows 21, rerunning

REPRODUCE WITH: gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.tools.VisualizationsToolIT.testVisualizationFound" -Dtests.seed=D165A70B3F17347A -Dtests.security.manager=false -Dtests.locale=frr-DE -Dtests.timezone=Africa/Brazzaville -Druntime.java=21

VisualizationsToolIT > testVisualizationFound STANDARD_ERROR
    REPRODUCE WITH: gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.tools.VisualizationsToolIT.testVisualizationFound" -Dtests.seed=D165A70B3F17347A -Dtests.security.manager=false -Dtests.locale=frr-DE -Dtests.timezone=Africa/Brazzaville -Druntime.java=21
    REPRODUCE WITH: gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.tools.VisualizationsToolIT.testVisualizationFound" -Dtests.seed=D165A70B3F17347A -Dtests.security.manager=false -Dtests.locale=frr-DE -Dtests.timezone=Africa/Brazzaville -Druntime.java=21

VisualizationsToolIT > testVisualizationFound FAILED
    org.opensearch.client.ResponseException: method [POST], host [http://127.0.0.1:59057/], URI [/_plugins/_ml/agents/rZcBJpQB8FffSoUkgPJ7/_execute], status line [HTTP/1.1 500 Internal Server Error]
    {"status":500,"error":{"type":"AEADBadTagException","reason":"System Error","details":"Tag mismatch"}}
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:501)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:384)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:359)
        at app//org.opensearch.ml.utils.TestHelper.makeRequest(TestHelper.java:182)
        at app//org.opensearch.ml.utils.TestHelper.makeRequest(TestHelper.java:155)

@ylwu-amzn ylwu-amzn merged commit b5dd5a1 into opensearch-project:main Jan 3, 2025
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants