Use Adagrad optimiser for Linear regression by default #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rithin-pullela-aws <[email protected]>
rithin-pullela-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
mingshl
reviewed
Dec 23, 2024
There was a problem hiding this comment.
Hi @rithin-pullela-aws, can you try adding test to verify this change?
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
dhrubo-os
reviewed
Dec 24, 2024
...lgorithms/src/main/java/org/opensearch/ml/engine/algorithms/regression/LinearRegression.java
Show resolved
Hide resolved
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
Signed-off-by: rithin-pullela-aws <[email protected]>
rithin-pullela-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
rithin-pullela-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
Signed-off-by: rithin-pullela-aws <[email protected]>
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
dhrubo-os
approved these changes
Dec 27, 2024
ylwu-amzn
approved these changes
Dec 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 30, 2024
* Use AdaGrad optimiser by default in Liner Resgression Signed-off-by: rithin-pullela-aws <[email protected]> * Added issue link in the code comment as a reference. Signed-off-by: rithin-pullela-aws <[email protected]> * Apply Spotless Signed-off-by: rithin-pullela-aws <[email protected]> --------- Signed-off-by: rithin-pullela-aws <[email protected]> (cherry picked from commit f323141)
dhrubo-os
pushed a commit
that referenced
this pull request
Dec 31, 2024
* Use AdaGrad optimiser by default in Liner Resgression Signed-off-by: rithin-pullela-aws <[email protected]> * Added issue link in the code comment as a reference. Signed-off-by: rithin-pullela-aws <[email protected]> * Apply Spotless Signed-off-by: rithin-pullela-aws <[email protected]> --------- Signed-off-by: rithin-pullela-aws <[email protected]> (cherry picked from commit f323141) Co-authored-by: Rithin Pullela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated default optimiser from SIMPLE_SGD to ADA_GRAD
Related Issues
Resolves #3210
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.