adding blue print doc for cohere multi-modal model #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhrubo Saha <[email protected]>
dhrubo-os
requested review from
b4sjoo,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
sam-herman
as code owners
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dhrubo-os
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
mingshl
reviewed
Nov 19, 2024
| @@ -0,0 +1,324 @@ | |||
| ### Cohere Embedding Connector Blueprint: | |||
|
|
|||
| This blueprint will show you how to connect a Cohere multi-modal embedding model to your Opensearch cluster, including creating a k-nn index and your own Embedding pipeline. You will require a Cohere API key to create a connector. | |||
| "url": "https://api.cohere.ai/v1/embed", | ||
| "headers": { | ||
| "Authorization": "Bearer ${credential.cohere_key}", | ||
| "Request-Source": "unspecified:opensearch" |
There was a problem hiding this comment.
is Request-Source required?
| POST /_plugins/_ml/models/<MODEL_ID>/_deploy | ||
| ``` | ||
|
|
||
| This will once again spawn a task to deploy your Model, with a response that will look like: |
There was a problem hiding this comment.
Model -> model. lower case
| GET /_plugins/_ml/tasks/<TASK_ID> | ||
| ``` | ||
|
|
||
| Once this is complete, your Model is deployed and ready! |
|
|
||
| ##### 1e. Test model | ||
|
|
||
| You can try this request to test that the Model behaves correctly: |
Signed-off-by: Dhrubo Saha <[email protected]>
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dhrubo-os
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
mingshl
previously approved these changes
Nov 19, 2024
ylwu-amzn
reviewed
Nov 19, 2024
| "id": { | ||
| "type": "text" | ||
| }, | ||
| "passage_embedding": { |
There was a problem hiding this comment.
How about changing to image_embedding ?
And passage_text -> image_base64
Signed-off-by: Dhrubo Saha <[email protected]>
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
ylwu-amzn
approved these changes
Nov 19, 2024
dhrubo-os
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
|
reran the bwc tests twice and still failing. can you look into it please? |
That's flaky. One BWC test is passing now. And this changes doesn't have any relation with the BWC test. |
mingshl
approved these changes
Nov 19, 2024
|
approved, but please create issue for the flaky test to track them or once it's merged, we cannot track the log |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-feature/multi_tenancy feature/multi_tenancy
# Navigate to the new working tree
cd .worktrees/backport-feature/multi_tenancy
# Create a new branch
git switch --create backport/backport-3229-to-feature/multi_tenancy
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 de301b739b2bdc590cfbdb28682a0b53c5988cdb
# Push it to GitHub
git push --set-upstream origin backport/backport-3229-to-feature/multi_tenancy
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-feature/multi_tenancyThen, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
* adding blue print doc Signed-off-by: Dhrubo Saha <[email protected]> * addressed comments Signed-off-by: Dhrubo Saha <[email protected]> * addressed comment Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit de301b7)
dhrubo-os
added
backport feature/multi_tenancy
and removed
backport feature/multi_tenancy
labels
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
* adding blue print doc Signed-off-by: Dhrubo Saha <[email protected]> * addressed comments Signed-off-by: Dhrubo Saha <[email protected]> * addressed comment Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit de301b7)
dhrubo-os
added a commit
that referenced
this pull request
Nov 19, 2024
* adding blue print doc Signed-off-by: Dhrubo Saha <[email protected]> * addressed comments Signed-off-by: Dhrubo Saha <[email protected]> * addressed comment Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit de301b7) Co-authored-by: Dhrubo Saha <[email protected]>
dhrubo-os
added a commit
that referenced
this pull request
Nov 19, 2024
* adding blue print doc Signed-off-by: Dhrubo Saha <[email protected]> * addressed comments Signed-off-by: Dhrubo Saha <[email protected]> * addressed comment Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit de301b7) Co-authored-by: Dhrubo Saha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[ adding blue print doc for cohere multi-modal model]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.