-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.14] Remove strict version dependency to compile minimum compatible version #2485 #3123
Merged
dhrubo-os
merged 1 commit into
opensearch-project:2.14
from
pyek-bot:backport_version_change
Dec 30, 2024
Merged
[Backport 2.14] Remove strict version dependency to compile minimum compatible version #2485 #3123
dhrubo-os
merged 1 commit into
opensearch-project:2.14
from
pyek-bot:backport_version_change
Dec 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompatible version (opensearch-project#2486) (opensearch-project#2523) * [Feature/multi_tenancy] Remove strict version dependency to compile minimum compatible version (opensearch-project#2485) * Remove strict version dependency to compile minimum compatible version Signed-off-by: Daniel Widdis <[email protected]> * Only declare version constants once Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Sicheng Song <[email protected]> * Remove unnecessary dependency Signed-off-by: Sicheng Song <[email protected]> * remove space Signed-off-by: Sicheng Song <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Sicheng Song <[email protected]> Co-authored-by: Daniel Widdis <[email protected]> (cherry picked from commit 954e8b3) Co-authored-by: Sicheng Song <[email protected]>
pyek-bot
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
sam-herman
as code owners
October 17, 2024 01:02
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
October 17, 2024 01:03 — with
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
October 17, 2024 01:03 — with
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
October 17, 2024 01:03 — with
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
October 17, 2024 01:03 — with
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
October 17, 2024 01:03 — with
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
October 17, 2024 01:03 — with
GitHub Actions
Error
Please add 2.13 backport label |
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
October 17, 2024 06:36 — with
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
October 17, 2024 06:36 — with
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
October 17, 2024 06:36 — with
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
October 17, 2024 06:36 — with
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
October 17, 2024 06:36 — with
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
October 17, 2024 06:36 — with
GitHub Actions
Error
5 tasks
pyek-bot
temporarily deployed
to
ml-commons-cicd-env
October 21, 2024 20:03 — with
GitHub Actions
Inactive
Zhangxunmt
approved these changes
Oct 21, 2024
Please re-run tests. Failing due to flaky tests. |
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
October 31, 2024 12:04 — with
GitHub Actions
Failure
dhrubo-os
approved these changes
Dec 30, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.13 2.13
# Navigate to the new working tree
cd .worktrees/backport-2.13
# Create a new branch
git switch --create backport/backport-3123-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 50cdb3f72b0ee231da12ee149700d9c8b835d5ba
# Push it to GitHub
git push --set-upstream origin backport/backport-3123-to-2.13
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.13 Then, create a pull request where the |
pyek-bot
added a commit
to pyek-bot/ml-commons
that referenced
this pull request
Dec 31, 2024
…ompatible version (opensearch-project#2486) (opensearch-project#2523) (opensearch-project#3123) * [Feature/multi_tenancy] Remove strict version dependency to compile minimum compatible version (opensearch-project#2485) * Remove strict version dependency to compile minimum compatible version * Only declare version constants once --------- * Remove unnecessary dependency * remove space --------- (cherry picked from commit 954e8b3) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Sicheng Song <[email protected]>
pyek-bot
added a commit
to pyek-bot/ml-commons
that referenced
this pull request
Jan 3, 2025
…ompatible version (opensearch-project#2486) (opensearch-project#2523) (opensearch-project#3123) * [Feature/multi_tenancy] Remove strict version dependency to compile minimum compatible version (opensearch-project#2485) * Remove strict version dependency to compile minimum compatible version * Only declare version constants once --------- * Remove unnecessary dependency * remove space --------- (cherry picked from commit 954e8b3) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Sicheng Song <[email protected]> Signed-off-by: Pavan Yekbote <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement:
[Feature/multi_tenancy] Remove strict version dependency to compile minimum compatible version ([Feature/multi_tenancy] Remove strict version dependency to compile minimum compatible version #2485)
Remove strict version dependency to compile minimum compatible version
Only declare version constants once
Remove unnecessary dependency
remove space
(cherry picked from commit 954e8b3)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.