Integrate Lucene Vector field with native engines to use KNNVectorFormat during segment creation #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
navneet1v
added
backport 2.x
Features
navneet1v
changed the title
|
Checking why CIs are failing. it doesn't seem the issue with the code. |
Does this mean if someone upgrades their index with knn=false, it is going to switch from binary doc values to lucene? |
To limit the scope of this pr and refactoring you are doing if its not a knn index we will still BDV |
jmazanec15
reviewed
Aug 9, 2024
src/main/java/org/opensearch/knn/index/mapper/KNNVectorFieldMapper.java
Outdated
Show resolved
Hide resolved
navneet1v
force-pushed
the
codec
branch
2 times, most recently
from
3b9a5a0 to
9958d0a
Compare
No. I have clarified the description now. I see how the confusion was happening. |
jmazanec15
previously approved these changes
Aug 11, 2024
Thanks. I am fixing the conflicts. Will raise the PR in few hours. |
jmazanec15
previously approved these changes
Aug 11, 2024
…mat during segment creation Signed-off-by: Navneet Verma <[email protected]>
jmazanec15
approved these changes
Aug 12, 2024
ryanbogan
approved these changes
Aug 12, 2024
src/main/java/org/opensearch/knn/index/mapper/KNNVectorFieldMapperUtil.java
Show resolved
Hide resolved
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
…mat during segment creation (#1945) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 5a5351f)
navneet1v
added a commit
that referenced
this pull request
Aug 12, 2024
…mat during segment creation (#1945) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 5a5351f)
navneet1v
added a commit
that referenced
this pull request
Aug 12, 2024
…mat during segment creation (#1945) (#1948) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 5a5351f) Co-authored-by: Navneet Verma <[email protected]>
akashsha1
pushed a commit
to akashsha1/k-NN
that referenced
this pull request
Sep 16, 2024
…mat during segment creation (opensearch-project#1945) Signed-off-by: Navneet Verma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate Lucene Vector field with native engines, to use KNNVectorFormat during segment creation
What has changed and why:
index.knnis false then we will use DocValuesBased Vector Field. Because if we use the Lucene based vector field then KNNCodec will not be triggered and default KNNFormat will be used which will create the HNSW graph as that is what default behavior of Lucene library. This is the reason why indexKNN check is added while deciding which VectorField to use.Related Issues
#1853
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.