-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement multi tenancy in Flow Framework #980
Draft
dbwiddis
wants to merge
29
commits into
opensearch-project:main
Choose a base branch
from
dbwiddis:multi-tenancy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
force-pushed
the
multi-tenancy
branch
2 times, most recently
from
December 13, 2024 21:55
60e881d
to
f611e41
Compare
dbwiddis
force-pushed
the
multi-tenancy
branch
10 times, most recently
from
December 27, 2024 21:39
090727f
to
8cd5b8f
Compare
dbwiddis
force-pushed
the
multi-tenancy
branch
from
December 28, 2024 03:40
8cd5b8f
to
7c10eac
Compare
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
multi-tenancy
branch
from
December 28, 2024 03:48
7c10eac
to
04da6bd
Compare
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
multi-tenancy
branch
from
December 28, 2024 20:06
04da6bd
to
1a9f856
Compare
dhrubo-os
reviewed
Dec 30, 2024
@@ -34,6 +34,22 @@ jobs: | |||
options: --user root | |||
|
|||
steps: | |||
# TEMPORARY until this is on Maven | |||
- name: Set up JDK 21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious why do we need to setup JDK again when are doing this at line 56?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the multitenant remote metadata client developed in ML Commons
feature/multi_tenancy
branch to migrate Flow Framework system indices to use the same pattern.Draft - WIP
Submitting in logical steps to ease maintainer review. Suggestions:
To use this locally, you will need to clone https://github.com/dbwiddis/opensearch-remote-metadata-sdk and run
./gradlew publishToMavenLocal
. That is in the process of getting its own repo with publication to maven; this is a temporary workaround to keep the work unblocked.Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.