Remove empty model_type parameter in anomaly detector suggestion agent template #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t template Signed-off-by: gaobinlong <[email protected]>
gaobinlong
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #959 +/- ##
=========================================
Coverage 77.57% 77.57%
Complexity 993 993
=========================================
Files 99 99
Lines 4714 4714
Branches 431 431
=========================================
Hits 3657 3657
Misses 877 877
Partials 180 180 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
owaiskazi19
approved these changes
Nov 14, 2024
dbwiddis
approved these changes
Nov 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
…t template (#959) Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 2f0a4ed) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Nov 19, 2024
…suggestion agent template (#968) Remove empty model_type parameter in anomaly detector suggestion agent template (#959) (cherry picked from commit 2f0a4ed) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's an empty model_type parameter existing in the anomaly detector suggestion agent template, which is unused and may introduce confusion, need to remove it.
Related Issues
No issue.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.