Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch9065 #9066

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Branch9065 #9066

merged 4 commits into from
Jan 15, 2025

Conversation

Arukris
Copy link
Contributor

@Arukris Arukris commented Jan 15, 2025

Description

Fixed the ondisk Binary quantization queries which missed the knn=true settings, the name and engine parameters within method{}.

Issues Resolved

Closes #[9065]

Version

2.18

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution, @Arukris!

@kolchfa-aws kolchfa-aws added backport 2.18 PR: Backport label for 2.18 backport 2.17 Backport for version 2.17 labels Jan 15, 2025
@kolchfa-aws kolchfa-aws merged commit b9b00e2 into opensearch-project:main Jan 15, 2025
5 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-9066-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9b00e2a196ef3e18c0c6bec06adada7cbf1ca87
# Push it to GitHub
git push --set-upstream origin backport/backport-9066-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-9066-to-2.17.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.18 2.18
# Navigate to the new working tree
pushd ../.worktrees/backport-2.18
# Create a new branch
git switch --create backport/backport-9066-to-2.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9b00e2a196ef3e18c0c6bec06adada7cbf1ca87
# Push it to GitHub
git push --set-upstream origin backport/backport-9066-to-2.18
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.18

Then, create a pull request where the base branch is 2.18 and the compare/head branch is backport/backport-9066-to-2.18.

@kolchfa-aws kolchfa-aws added backport 2.18 PR: Backport label for 2.18 and removed backport 2.18 PR: Backport label for 2.18 labels Jan 15, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 15, 2025
* fixing quantization queries - wip

Signed-off-by: Aruna Govindaraju <[email protected]>

* Fixed ondisk binary quantization queries

Signed-off-by: Aruna Govindaraju <[email protected]>

---------

Signed-off-by: Aruna Govindaraju <[email protected]>
Co-authored-by: Aruna Govindaraju <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit b9b00e2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kolchfa-aws kolchfa-aws added backport 2.17 Backport for version 2.17 and removed backport 2.17 Backport for version 2.17 labels Jan 15, 2025
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-9066-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9b00e2a196ef3e18c0c6bec06adada7cbf1ca87
# Push it to GitHub
git push --set-upstream origin backport/backport-9066-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-9066-to-2.17.

kolchfa-aws added a commit that referenced this pull request Jan 15, 2025
* fixing quantization queries - wip



* Fixed ondisk binary quantization queries



---------




(cherry picked from commit b9b00e2)

Signed-off-by: Aruna Govindaraju <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aruna Govindaraju <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.17 Backport for version 2.17 backport 2.18 PR: Backport label for 2.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants