Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Character filters - Mapping #8556

Merged
merged 5 commits into from
Jan 3, 2025
Merged

[DOC] Character filters - Mapping #8556

merged 5 commits into from
Jan 3, 2025

Conversation

leanneeliatra
Copy link
Contributor

Description

Updates:

  1. Updating the OpenSearch documentation to include a page on Mappings Character filters in the analyzers section.
  2. Updated the heading on the HTML Strip Character Filter page to match formatting across docs.

Issues Resolved

Both updates are related to #1483 and address part of #1483.

Version

all

Frontend features

n/a

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@leanneeliatra leanneeliatra mentioned this pull request Oct 17, 2024
Closed
1 task
@kolchfa-aws kolchfa-aws assigned vagimeli and unassigned kolchfa-aws Oct 17, 2024
@vagimeli vagimeli added 3 - Tech review PR: Tech review in progress Needs SME Waiting on input from subject matter expert Content gap analyzers labels Oct 17, 2024
@vagimeli
Copy link
Contributor

@udabhas @varun-lodaya Please provide tech review approval to move this PR forward in the documentation process. Please ensure content and code examples are relevant and accurate. Thank you.

udabhas
udabhas reviewed Dec 10, 2024
View reviewed changes
_analyzers/character-filters/mapping-character-filter.md Outdated
Using the mapping filter on the following text "I have III apples and IV oranges" with the mappings provided produces the response text:

```
I have 3 apples and 4 oranges
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the above example Output would be 1 not I

1 have 3 apples and 4 oranges

@kolchfa-aws
Doc review
7252117 
Signed-off-by: Fanit Kolchina <[email protected]>
natebower
natebower reviewed Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws @leanneeliatra One minor change. Thanks!

_analyzers/character-filters/mapping-character-filter.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws merged commit a320d05 into opensearch-project:main Jan 3, 2025
6 checks passed
@kolchfa-aws kolchfa-aws assigned kolchfa-aws and unassigned vagimeli Jan 3, 2025
@kolchfa-aws kolchfa-aws added the backport 2.18 PR: Backport label for 2.18 label Jan 3, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 3, 2025
@github-actions @vagimeli
@kolchfa-aws @natebower
[DOC] Character filters - Mapping (#8556)
6b0e220 
* doc: Adding mapping character filter page and update to title on HTML strip

Signed-off-by: [email protected] <[email protected]>

* Doc review

Signed-off-by: Fanit Kolchina <[email protected]>

* Update _analyzers/character-filters/mapping-character-filter.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: Melissa Vagi <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit a320d05)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 3, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 3, 2025
@opensearch-trigger-bot
[DOC] Character filters - Mapping (#8556) (#9014)
74404ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@udabhas udabhas udabhas left review comments

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@kolchfa-aws kolchfa-aws

Labels
3 - Tech review PR: Tech review in progress analyzers backport 2.18 PR: Backport label for 2.18 Content gap Needs SME Waiting on input from subject matter expert
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leanneeliatra @vagimeli @udabhas @natebower @kolchfa-aws