[DOC] Tokenizers - Classic #8357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
leanneeliatra
requested review from
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
vagimeli
added
3 - Tech review
|
@udabhas Will you review this PR for technical accuracy, or have a peer review it? Thank you. |
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
udabhas
reviewed
Dec 9, 2024
| By analyzing the text "Send an email to [email protected] or call 555-1234!", we can see the punctuation has been removed, while email and phone number | ||
|
|
||
| ``` | ||
| "Send", "an", "email", "to", "john.doe", "example.com", "or", "call", "555-1234" |
There was a problem hiding this comment.
nit: I was wondering if it would be better to show entire output as there are different token types.
{"<ALPHANUM>", "<APOSTROPHE>", "<ACRONYM>", "<COMPANY>", "<EMAIL>", "<HOST>", "<NUM>", "<CJ>", "<ACRONYM_DEP>"}
{
"tokens": [
{
"token": "Send",
"start_offset": 0,
"end_offset": 4,
"type": "<ALPHANUM>",
"position": 0
},
{
"token": "an",
"start_offset": 5,
"end_offset": 7,
"type": "<ALPHANUM>",
"position": 1
},
{
"token": "email",
"start_offset": 8,
"end_offset": 13,
"type": "<ALPHANUM>",
"position": 2
},
{
"token": "to",
"start_offset": 14,
"end_offset": 16,
"type": "<ALPHANUM>",
"position": 3
},
{
"token": "[email protected]",
"start_offset": 17,
"end_offset": 37,
"type": "<EMAIL>",
"position": 4
},
{
"token": "or",
"start_offset": 38,
"end_offset": 40,
"type": "<ALPHANUM>",
"position": 5
},
{
"token": "call",
"start_offset": 41,
"end_offset": 45,
"type": "<ALPHANUM>",
"position": 6
},
{
"token": "555-1234",
"start_offset": 46,
"end_offset": 54,
"type": "<NUM>",
"position": 7
}
]
}
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
natebower
requested changes
Jan 3, 2025
There was a problem hiding this comment.
@kolchfa-aws Please see my comments and changes and tag me for approval when complete. Thanks!
| The `classic` tokenizer parses text as follows: | ||
|
|
||
| - **Punctuation**: Splits text at most punctuation marks and removes punctuation characters. Dots that aren't followed by spaces are treated as part of the token. | ||
| - **Hyphens**: Splits words at hyphens, except when a number is present. When a number is present in a token, the token is not split and is treated like a product number. |
There was a problem hiding this comment.
Like a "product number" specifically?
kolchfa-aws
reviewed
Jan 3, 2025
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
|
@natebower Comments addressed - please review again. Thanks! |
natebower
reviewed
Jan 3, 2025
natebower
approved these changes
Jan 3, 2025
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
* adding in classic tokenizer page Signed-off-by: [email protected] <[email protected]> * removing unneeded whitespace Signed-off-by: [email protected] <[email protected]> * tokenizers does now have children Signed-off-by: [email protected] <[email protected]> * doc: small update for page numbers Signed-off-by: [email protected] <[email protected]> * format: updates to layout and formatting of page Signed-off-by: [email protected] <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Change example Signed-off-by: Fanit Kolchina <[email protected]> * Small rewrite Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Update _analyzers/tokenizers/classic.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: [email protected] <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit cdf2e30) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addition of the Tokenizer - Classic documentation, to the Analyzers section.
Issues Resolved
Part of #1483 addressed in this PR.
Version
All
Frontend features
n/a
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.