Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi data source dependencies plugins #683

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Oct 9, 2024

Description

Add "dataSource", "dataSourceManagement" to maps-dashboards plugin as dependencies for region maps multi data source.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@junqiu-lei junqiu-lei merged commit 37c576f into opensearch-project:main Oct 9, 2024
21 checks passed
@junqiu-lei junqiu-lei deleted the fix-region-map-mds branch October 9, 2024 22:43
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-683-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37c576f7826a2549083b4aefc3d4aef4af737aa7
# Push it to GitHub
git push --set-upstream origin backport/backport-683-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-683-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants