Revert "feat: only support visual editor alerts to navigate to discover" #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raintygao
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
wanglam
as code owners
…er (opensearch-project#368) (opensearch-project#370)" This reverts commit 2ba4853. Signed-off-by: tygao <[email protected]>
raintygao
force-pushed
the
revert-2.18
branch
from
2fc73a1 to
29fbf69
Compare
wanglam
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
LGTM.
There is no file diffs between 2.18.0 tag and pulled branch.
2.18.0.0...raintygao:dashboards-assistant:revert-2.18
ruanyl
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts commit 2ba4853(feat: only support visual editor alerts to navigate to discover).
Description
Revert this PR as it's not included in 2.18, this PR is a very minor change and not depended by others so it will be released in 2.19.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.