Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UX change #364

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Minor UX change #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b77a845
Minor UX change
qianheng-aws Oct 29, 2024
164c1ac
Update CHANGELOG.md
qianheng-aws Oct 29, 2024
e40783b
Hide trace icon in insight page
qianheng-aws Oct 29, 2024
79b01e3
Merge remote-tracking branch 'refs/remotes/origin/main' into UXChange
qianheng-aws Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- feat: edit visualization with natural language in a dialog([#351](https://github.com/opensearch-project/dashboards-assistant/pull/351))
- fix: Update alerting DSL verify mechanism([#359](https://github.com/opensearch-project/dashboards-assistant/pull/359))
- fix: Refactor contextProvider get to reduce re-fetch([#365](https://github.com/opensearch-project/dashboards-assistant/pull/365))
- fix: minor UX change([#364](https://github.com/opensearch-project/dashboards-assistant/pull/364))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the change log a bit more detailed?



### 📈 Features/Enhancements
Expand Down
15 changes: 15 additions & 0 deletions public/assets/filled_sparkle.svg
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I created a PR to add this button to OUI opensearch-project/oui#1452
It looks the svg you use here is different from the one that I have in the PR.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions public/components/incontext_insight/generate_popover_body.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,16 +297,16 @@ export const GeneratePopoverBody: React.FC<{
</EuiFlexItem>
<EuiFlexItem>
<EuiText>
<EuiTitle size="xxs">
<h6>
<EuiTitle size="xxxs">
<p>
{showInsight
? i18n.translate('assistantDashboards.inContextInsight.withRAGSummary', {
defaultMessage: 'Insight With RAG',
})
: i18n.translate('assistantDashboards.inContextInsight.summary', {
defaultMessage: 'Summary',
})}
</h6>
</p>
</EuiTitle>
</EuiText>
</EuiFlexItem>
Expand Down Expand Up @@ -338,7 +338,7 @@ export const GeneratePopoverBody: React.FC<{
<MessageActions
contentToCopy={insight}
showFeedback
showTraceIcon={insightAvailable}
showTraceIcon={false}
onViewTrace={() => {}}
usageCollection={usageCollection}
isOnTrace={showInsight}
Expand Down
4 changes: 2 additions & 2 deletions public/components/incontext_insight/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import { IncontextInsight as IncontextInsightInput } from '../../types';
import { getIncontextInsightRegistry, getNotifications } from '../../services';
// TODO: Replace with getChrome().logos.Chat.url
import chatIcon from '../../assets/chat.svg';
import sparkle from '../../assets/sparkle.svg';
import filled_sparkle from '../../assets/filled_sparkle.svg';
import { HttpSetup, StartServicesAccessor } from '../../../../../src/core/public';
import { GeneratePopoverBody } from './generate_popover_body';
import { UsageCollectionSetup } from '../../../../../src/plugins/usage_collection/public/plugin';
Expand Down Expand Up @@ -270,7 +270,7 @@ export const IncontextInsight = ({
</EuiFlexItem>
<EuiFlexItem grow={1}>
<div className="incontextInsightAnchorIcon">
<EuiIcon type={input.type === 'generate' ? sparkle : chatIcon} size="l" />
<EuiIcon type={input.type === 'generate' ? filled_sparkle : chatIcon} size="l" />
</div>
</EuiFlexItem>
</EuiFlexGroup>
Expand Down
Loading