Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display ai actions that compatible with the datasource #350

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Oct 15, 2024

Description

[Describe what this change achieves]

Screen.Recording.2024-10-15.at.17.44.07.mov

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@gaobinlong gaobinlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gaobinlong
Copy link
Collaborator

@ruanyl please add a changelog for this PR so that we can get it merged.

Signed-off-by: Yulong Ruan <[email protected]>
@ruanyl ruanyl merged commit 19ca923 into opensearch-project:main Oct 17, 2024
9 checks passed
@ruanyl ruanyl added the backport 2.x Trigger the backport flow to 2.x label Oct 17, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 17, 2024
* feat: do not display AI actions if the selected data source is incompatible

Signed-off-by: Yulong Ruan <[email protected]>

* refactor: add data source id to action context

Signed-off-by: Yulong Ruan <[email protected]>

* chore: update CHANGELOG

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
(cherry picked from commit 19ca923)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ruanyl pushed a commit that referenced this pull request Oct 17, 2024
)

* feat: do not display AI actions if the selected data source is incompatible

Signed-off-by: Yulong Ruan <[email protected]>

* refactor: add data source id to action context

Signed-off-by: Yulong Ruan <[email protected]>

* chore: update CHANGELOG

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
(cherry picked from commit 19ca923)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Trigger the backport flow to 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants