BugFix: [AlertInsight] Remove the cache of insight agent id in node server #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heng Qian <[email protected]>
qianheng-aws
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
yuye-aws
reviewed
Oct 9, 2024
public/components/incontext_insight/generate_popover_body.test.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
Hailong-am
reviewed
Oct 10, 2024
Hailong-am
reviewed
Oct 10, 2024
Signed-off-by: Heng Qian <[email protected]>
ruanyl
approved these changes
Oct 11, 2024
Hailong-am
approved these changes
Oct 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
…erver (#343) * BugFix: [AlertInsight] Remove the cache of insight id in node server Signed-off-by: Heng Qian <[email protected]> * Add CHANGELOG.md Signed-off-by: Heng Qian <[email protected]> * Change log level to debug if not finding insight agent id Signed-off-by: Heng Qian <[email protected]> * Hide insight agent id in response Signed-off-by: Heng Qian <[email protected]> * Minor fix Signed-off-by: Heng Qian <[email protected]> * Minor fix Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 4968f75) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Hailong-am
pushed a commit
that referenced
this pull request
Oct 11, 2024
…erver (#343) (#344) * BugFix: [AlertInsight] Remove the cache of insight id in node server Signed-off-by: Heng Qian <[email protected]> * Add CHANGELOG.md Signed-off-by: Heng Qian <[email protected]> * Change log level to debug if not finding insight agent id Signed-off-by: Heng Qian <[email protected]> * Hide insight agent id in response Signed-off-by: Heng Qian <[email protected]> * Minor fix Signed-off-by: Heng Qian <[email protected]> * Minor fix Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 4968f75) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the cache of insight agent id in node server.
Pass insight agent id to front-end to indicate that the agent exists, and then the front-end can use the agent id in its next request directly to retrieve insight.Detect insight agent id twice to remove the cache:
There will be an potential issue that different requests could be sent to different nodes server and cause error if depending on the cache of insight agent id.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.