[BUG] Change time format to UTC in notification message preview #1183
+192
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix an improper import Signed-off-by: vikhy-aws <[email protected]>
vikhy-aws
requested review from
lezzago,
AWSHurneyt,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya and
riysaxen-amzn
as code owners
riysaxen-amzn
previously approved these changes
Jan 3, 2025
AWSHurneyt
reviewed
Jan 6, 2025
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
AWSHurneyt
changed the title
AWSHurneyt
previously approved these changes
Jan 6, 2025
…ailing cypress test Signed-off-by: vikhy-aws <[email protected]>
…cypress test Signed-off-by: vikhy-aws <[email protected]>
…cypress test Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
|
Cypress test which is failing is a flaky test which is known to fail sometimes. Even other merged PRs have seen this fail as well -- #1159 (comment) This PR is not related to the failing flaky test and does not cause/affect the test. |
Signed-off-by: vikhy-aws <[email protected]>
AWSHurneyt
approved these changes
Jan 7, 2025
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.9 2.9
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.9
# Create a new branch
git switch --create backport-1183-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.9Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.8 2.8
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.8
# Create a new branch
git switch --create backport-1183-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.8
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.8Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.7 2.7
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.7
# Create a new branch
git switch --create backport-1183-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.7
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.7Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.4 2.4
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.4
# Create a new branch
git switch --create backport-1183-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.4
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.4Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.11
# Create a new branch
git switch --create backport-1183-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.11Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.15
# Create a new branch
git switch --create backport-1183-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.15Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.0 2.0
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.0
# Create a new branch
git switch --create backport-1183-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.0Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.17
# Create a new branch
git switch --create backport-1183-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.17Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.3 2.3
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.3
# Create a new branch
git switch --create backport-1183-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.3Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.14 2.14
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.14
# Create a new branch
git switch --create backport-1183-to-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.14
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.14Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.1 2.1
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.1
# Create a new branch
git switch --create backport-1183-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.1Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.16
# Create a new branch
git switch --create backport-1183-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.16Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.18 2.18
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.18
# Create a new branch
git switch --create backport-1183-to-2.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.18
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.18Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.10 2.10
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.10
# Create a new branch
git switch --create backport-1183-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.10
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.10Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.2 2.2
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.2
# Create a new branch
git switch --create backport-1183-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.2
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.2Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.5 2.5
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.5
# Create a new branch
git switch --create backport-1183-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.5
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.5Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.6 2.6
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.6
# Create a new branch
git switch --create backport-1183-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.6
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.6Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.12
# Create a new branch
git switch --create backport-1183-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.12Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.13 2.13
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.13
# Create a new branch
git switch --create backport-1183-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47800b70e5cd3e25b2c1a14ce35f97516dcb10b7
# Push it to GitHub
git push --set-upstream origin backport-1183-to-2.13
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.13Then, create a pull request where the |
vikhy-aws
added a commit
to vikhy-aws/alerting-dashboards-plugin
that referenced
this pull request
Jan 7, 2025
…search-project#1183) * fix: change notification preview message to have time in UTC format. fix an improper import Signed-off-by: vikhy-aws <[email protected]> * fix: add unit tests. change timezone to UTC Signed-off-by: vikhy-aws <[email protected]> * fix: remove log statements Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for loadSampleEcommerceData to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for monitor creation to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for monitor creation to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: revert timeout increases. Handle monitors page load properly. Signed-off-by: vikhy-aws <[email protected]> * fix: revert changes to timeouts Signed-off-by: vikhy-aws <[email protected]> * fix: increase timeouts to ensure proper loading of pages Signed-off-by: vikhy-aws <[email protected]> --------- Signed-off-by: vikhy-aws <[email protected]>
AWSHurneyt
pushed a commit
that referenced
this pull request
Jan 8, 2025
… (#1184) * fix: change notification preview message to have time in UTC format. fix an improper import * fix: add unit tests. change timezone to UTC * fix: remove log statements * fix: update timeout for loadSampleEcommerceData to 60secs to handle failing cypress test * fix: update timeout for monitor creation to 60secs to handle failing cypress test * fix: update timeout for monitor creation to 60secs to handle failing cypress test * fix: revert timeout increases. Handle monitors page load properly. * fix: revert changes to timeouts * fix: increase timeouts to ensure proper loading of pages --------- Signed-off-by: vikhy-aws <[email protected]>
vikhy-aws
added a commit
to vikhy-aws/alerting-dashboards-plugin
that referenced
this pull request
Jan 8, 2025
…search-project#1183) * fix: change notification preview message to have time in UTC format. fix an improper import Signed-off-by: vikhy-aws <[email protected]> * fix: add unit tests. change timezone to UTC Signed-off-by: vikhy-aws <[email protected]> * fix: remove log statements Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for loadSampleEcommerceData to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for monitor creation to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for monitor creation to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: revert timeout increases. Handle monitors page load properly. Signed-off-by: vikhy-aws <[email protected]> * fix: revert changes to timeouts Signed-off-by: vikhy-aws <[email protected]> * fix: increase timeouts to ensure proper loading of pages Signed-off-by: vikhy-aws <[email protected]> --------- Signed-off-by: vikhy-aws <[email protected]>
vikhy-aws
added a commit
to vikhy-aws/alerting-dashboards-plugin
that referenced
this pull request
Jan 8, 2025
…search-project#1183) * fix: change notification preview message to have time in UTC format. fix an improper import Signed-off-by: vikhy-aws <[email protected]> * fix: add unit tests. change timezone to UTC Signed-off-by: vikhy-aws <[email protected]> * fix: remove log statements Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for loadSampleEcommerceData to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for monitor creation to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for monitor creation to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: revert timeout increases. Handle monitors page load properly. Signed-off-by: vikhy-aws <[email protected]> * fix: revert changes to timeouts Signed-off-by: vikhy-aws <[email protected]> * fix: increase timeouts to ensure proper loading of pages Signed-off-by: vikhy-aws <[email protected]> --------- Signed-off-by: vikhy-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the notification message preview's time to UTC format. Fix an improper import causing problems in acknowledging the alerts.
Issues Resolved
Resolves issue #1173
Fix an improper import causing problems in acknowledging the alerts
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.