fix: error toast message while configuring trigger while creating a monitor #1178
+245
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onitor Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
vikhy-aws
requested review from
lezzago,
AWSHurneyt,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya and
riysaxen-amzn
as code owners
amsiglan
reviewed
Dec 20, 2024
package.json
Outdated
| @@ -34,7 +34,7 @@ | |||
| "@babel/plugin-transform-modules-commonjs": "^7.22.9", | |||
| "@elastic/elastic-eslint-config-kibana": "link:../../packages/opensearch-eslint-config-opensearch-dashboards", | |||
| "@elastic/eslint-import-resolver-kibana": "link:../../packages/osd-eslint-import-resolver-opensearch-dashboards", | |||
| "cypress": "9.5.4", | |||
| "cypress": "12.17.4", | |||
There was a problem hiding this comment.
why are we changing this? Have other plugins updated it as well?
There was a problem hiding this comment.
So, the version of cypress in OpenSearch-Dashboards and the version of cypress in all the plugins should match for the frontend to run. So, set them to the same value.
There was a problem hiding this comment.
LMK if this needs to be updated or not?
amsiglan
reviewed
Dec 20, 2024
public/pages/CreateTrigger/containers/ConfigureActions/ConfigureActions.js
Outdated
Show resolved
Hide resolved
amsiglan
reviewed
Dec 20, 2024
amsiglan
reviewed
Dec 20, 2024
Signed-off-by: vikhy-aws <[email protected]>
amsiglan
previously approved these changes
Dec 21, 2024
Signed-off-by: vikhy-aws <[email protected]>
riysaxen-amzn
approved these changes
Dec 22, 2024
eirsep
reviewed
Dec 23, 2024
| @@ -182,8 +182,9 @@ class ConfigureActions extends React.Component { | |||
| type: toChannelType(destination.type), | |||
| description: '', | |||
| })); | |||
| } else { | |||
| backendErrorNotification(notifications, 'load', 'destinations', response.err); | |||
| } else if (response.totalMonitors !== 0) { | |||
There was a problem hiding this comment.
Am hazy on my JS but are you intending to check response.totalMonitor > 0
if yes, why are we checking for >0 and then code comment says config index not created?
There was a problem hiding this comment.
So, the config index will be created automatically when the monitor is created. So, when the totalMonitors is 0 it is expected that the config index has not been created, and we don't want to show that error popup to the user.
amsiglan
approved these changes
Dec 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
…onitor (#1178) * fix: error toast message while configuring trigger while creating a monitor Signed-off-by: vikhy-aws <[email protected]> * fix: gracefully handle exceptions related to config index not created Signed-off-by: vikhy-aws <[email protected]> * fix: gracefully handle exceptions related to config index not created Signed-off-by: vikhy-aws <[email protected]> * fix: fix unit test to conform to code changes Signed-off-by: vikhy-aws <[email protected]> --------- Signed-off-by: vikhy-aws <[email protected]> (cherry picked from commit ad86031) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Jan 9, 2025
…onitor (#1178) (#1179) * fix: error toast message while configuring trigger while creating a monitor * fix: gracefully handle exceptions related to config index not created * fix: gracefully handle exceptions related to config index not created * fix: fix unit test to conform to code changes --------- (cherry picked from commit ad86031) Signed-off-by: vikhy-aws <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue of an unnecessary error popup appearing while creation of a monitor. The error popup is raised because the config index is not been before a monitor is created, but is created automatically when the monitor is created. So, the error popup is redundant when creating a monitor.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.