Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building as dynamic module support #9

Closed
wants to merge 3 commits into from
Closed

Building as dynamic module support #9

wants to merge 3 commits into from

Conversation

cryptofuture
Copy link

Ability to build module as dynamic nginx module. (converted to dynamic)
Description here.

@agentzh
Copy link
Member

agentzh commented May 3, 2016

@cryptofuture Please review the patch from pull request #4 since that pull request requires its own review and modification process. In general, pull requests should be minimal and self-contained.

@cryptofuture
Copy link
Author

I added it after this pull request in fork I use for nginx ppa I maintain. Sorry, I didn't thought about applying request 4 in new branch. Basically you can apply request #4 first (since nothing bad with it), then apply #9 , or merge it separately. Otherwise I can just close this one, refork things and recreate pure pull request (will do it if you don't reply next hour)

This reverts commit 04c3f25.
@cryptofuture cryptofuture reopened this May 4, 2016
@agentzh
Copy link
Member

agentzh commented May 4, 2016

@cryptofuture #4 cannot be merged as-is. It requires coding style fixes at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants