I improved healthcheck library so that it supports contains / exact matc... #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atching on monitor response body.
|
@rcosnita This has been on my TODO list and I'm glad you have looked into this! I'll check out your patch as soon as I can manage. Thank you! |
|
any news here? |
|
As far as I know the change was not integrated. |
|
I'll look into this :) |
| } | ||
|
|
||
| if ctx.http_version ~= "1.1" or ctx.http_version ~= "1.0" then |
There was a problem hiding this comment.
shouldn't this be an AND operator?
You probably want;
if ctx.http_version ~= "1.0" then
ctx.http_version = "1.1"
endThere was a problem hiding this comment.
I just commented on the line, but actually the checks should be done further up, before the ctx table is created.
and then it should be something like;
local http_allowed = { ["1.0"] = true, ["1.1"] = true }
local http_version = opts.http_version or "1.1"
if not http_allowed[http_version] then
return nil, "invalid http version: "..tostring(http_version)
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently needed to monitor upstreams and decided based on received body if an upstream member is healthy or not. I updated your library so that it supports this.