On Vehicle Updated Hook #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codecat
reviewed
Jan 5, 2024
Comment on lines
+80
to
+82
| #if TMNEXT | ||
| UI::LabelText("Entity ID from player", Text::Format("%08x", VehicleState::GetPlayerVehicleID(player))); | ||
| #endif |
There was a problem hiding this comment.
Did I break Maniaplanet/Turbo with this change? 😅 Perhaps this would be good in its own PR if there's a compiler error on the other games.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a draft PR for the on update hook. I found a spot in MP4 that also works for disabling skidmarks (this was my test case, plugin attached).
I couldn't find one in Turbo and decided it wasn't worth the effort at this stage.
skidless-ghosts-0.1.0.op.zip