Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle notMember / 403 error when accessing private club activity #111

Open
Fort-TM opened this issue Oct 16, 2024 · 1 comment
Open

Handle notMember / 403 error when accessing private club activity #111

Fort-TM opened this issue Oct 16, 2024 · 1 comment
Assignees
@davidbmaier
Labels
bug Something isn't working

Comments

@Fort-TM
Copy link

Fort-TM commented Oct 16, 2024 •
edited
Loading

Issue

When opening any private club activity (e.g. this one from the ITB club), the site will display the following error:

error 403 from server: ["clubMemberRole:error-notMember"] (json: cannot unmarshal array into Go value of type nadeo.errorResponse)

Suggestion

Properly handle the error and display a more user-friendly / readable message

Screenshots

The error in question:
image
@Fort-TM Fort-TM mentioned this issue Oct 16, 2024
Closed
@davidbmaier davidbmaier self-assigned this Oct 17, 2024
@davidbmaier davidbmaier added the bug Something isn't working label Oct 17, 2024
@davidbmaier
Copy link
Member

davidbmaier commented Oct 17, 2024 •
edited
Loading

Had a look, this will need some deeper changes in gonadeo's error handling (which always assumes Nadeo's error messages are valid Error/Message objects when they're sometimes just string arrays) so I'll look into that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidbmaier davidbmaier

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidbmaier @Fort-TM