Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable button / link to tm.com for private activities #112

Closed
Fort-TM opened this issue Oct 16, 2024 · 2 comments
Closed

Disable button / link to tm.com for private activities #112

Fort-TM opened this issue Oct 16, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Fort-TM
Copy link

Fort-TM commented Oct 16, 2024

Issue

Private activities are not accessible by tm.io, since the internal account isn't a member of any clubs. As such, the site will display a notMember error (see #111), regardless of the club

Suggestion

As explained by tooInfinite on Discord

Might be worth checking if we can already see the private field from the club data, so we could disable the button or show some kind of info before you land on an error page

it would make sense to disable the button to access the activity, and maybe include a button to access it on https://www.trackmania.com/ instead (the latter would require logging in on tm.com to see the activity)

@davidbmaier davidbmaier self-assigned this Oct 17, 2024
@davidbmaier davidbmaier added the enhancement New feature or request label Oct 17, 2024
@davidbmaier
Copy link
Member

Fixed, private campaigns should no longer be accessible via the UI.

@Fort-TM
Copy link
Author

Fort-TM commented Oct 25, 2024

Confirmed fixed, private activities don't show any buttons now. Thanks👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants