-
Notifications
You must be signed in to change notification settings - Fork 83
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding a pull request template (#248)
- Loading branch information
1 parent
5467981
commit f081447
Showing
1 changed file
with
38 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
<!--- Add a pull request title above in this format --> | ||
<!--- real example: 'SDK-306: Integrated Micro Frontend Tooling Setup in OpenMRS SDK' --> | ||
<!--- 'TRUNK-JiraIssueNumber: JiraIssueTitle' --> | ||
## Description of what I changed | ||
<!--- Describe your changes in detail --> | ||
<!--- It can simply be your commit message, which you must have --> | ||
|
||
## Issue I worked on | ||
<!--- This project only accepts pull requests related to open issues --> | ||
<!--- Want a new feature or change? Discuss it in an issue first! --> | ||
<!--- Found a bug? Point us to the issue/or create one, so we can reproduce it! --> | ||
<!--- Just add the issue number at the end: --> | ||
see https://issues.openmrs.org/browse/SDK- | ||
|
||
## Checklist: I completed these to help reviewers :) | ||
<!--- Put an `x` in the box if you did the task --> | ||
<!--- If you forgot a task, please follow the instructions below --> | ||
- [ ] My IDE is configured to follow the [**code style**](https://wiki.openmrs.org/display/docs/Java+Conventions) of this project. | ||
|
||
No? Unsure? -> [configure your IDE](https://wiki.openmrs.org/display/docs/How-To+Setup+And+Use+Your+IDE), format the code and add the changes with `git add . && git commit --amend` | ||
|
||
- [ ] I have **added tests** to cover my changes. (If you refactored | ||
existing code that was well tested you do not have to add tests) | ||
|
||
No? -> write tests and add them to this commit `git add . && git commit --amend` | ||
|
||
- [ ] I ran `mvn clean install` right before creating this pull request and | ||
added all formatting changes to my commit. | ||
|
||
No? -> execute the above command | ||
|
||
- [ ] All new and existing **tests passed**. | ||
|
||
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works. | ||
|
||
- [ ] My pull request is **based on the latest changes** of the master branch. | ||
|
||
No? Unsure? -> execute command `git pull --rebase upstream master` |