Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to restrict XSS filtering #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Nov 16, 2024

Tries to limit the application of the XSS filter.

@dkayiwa
Copy link
Member

dkayiwa commented Nov 16, 2024

Will this prevent someone from submitting stored XSS via our REST calls?

@ibacher
Copy link
Member Author

ibacher commented Nov 16, 2024

In so far as they work on form parameters, it will. We need a slightly different solution for the REST API, though, as HTML-encoding will break anything where we expect the client to submit XML since, e.g.,

<?xml version="1.0"?>
<document />

Becomes

&lt;?xml version="1.0"?&gt;
&lt;document /&gt;

which won’t be parsed correctly. Basically for REST, we need to HTML encode the values as they are deserialised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants