-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LUI-197 UI for saving concept reference ranges #196
Open
dicksonmulli
wants to merge
32
commits into
openmrs:master
Choose a base branch
from
dicksonmulli:LUI-197-ui-to-add-reference-ranges
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
97bd354
Initial commit
dicksonmulli 45c5846
Concept references header on the UI
dicksonmulli 8004fd8
Showing reference range title and table headers
dicksonmulli c6ee428
Concept reference form - restructured
dicksonmulli 0b72cf4
Showing saved data
dicksonmulli 3d6c088
Updating concept page with reference ranges
dicksonmulli 1af1c3d
Successfully saving new data
dicksonmulli 9bcb15c
Hiding reference ranges when concept type is not numeric
dicksonmulli 24963af
Updating version for testing purposes
dicksonmulli c888df0
Removing an existing row on the UI
dicksonmulli 2695383
Adding tests
dicksonmulli 71860fd
Hiding and showing referenceRange row on conceptForm
dicksonmulli 5fee0d8
Creating a reflection object of reference range
dicksonmulli cd19cda
Using reflection to map reference ranges
dicksonmulli 46e9cdf
Updating reflection in tests
dicksonmulli a43a391
Code refactor
dicksonmulli a1c1f4d
Update reference ranges
dicksonmulli 04dfa3f
Reverting the core version
dicksonmulli 270311a
Sorting reference ranges
dicksonmulli d3dd833
Fixing null pointer
dicksonmulli 6cd4978
Code refactor
dicksonmulli 36634bb
Ability to edit concept reference ranges
dicksonmulli 2194cfb
Updating reference range validations
dicksonmulli 71fea3e
Reconciliation of admin and dictionary views
dicksonmulli 29ffdac
Fixing an error when 2 rows are added and the first one removed befor…
dicksonmulli a66e598
Conditional display of concept reference ranges based on openMRS-core…
dicksonmulli dd54bf1
Refactoring
dicksonmulli 988d917
code refactor
dicksonmulli a98b735
code refactor
dicksonmulli 2be1fed
removed unnecessary method
dicksonmulli 234fb75
Hidding concept set row when checkbox is not clicked
dicksonmulli 695d589
Showing 'Is set' when checkbox is checked
dicksonmulli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cimplicated and brittle. Why don't you use the same trick of trying to load a class like concept reference range which was added in 2.7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This boolean is used in UI/JSP hence the need to check the version instead of loading a particular class. I think this will be reliable as long as we have the version constant(s).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can still have a boolean with loading a particular class.