-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding vtkhdf option to write vtk data #3252
Open
jon-proximafusion
wants to merge
7
commits into
openmc-dev:develop
Choose a base branch
from
shimwell:adding_hdf_option_to_write_vtk_data
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding vtkhdf option to write vtk data #3252
jon-proximafusion
wants to merge
7
commits into
openmc-dev:develop
from
shimwell:adding_hdf_option_to_write_vtk_data
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimwell
reviewed
Jan 9, 2025
mwestphal
reviewed
Jan 9, 2025
jon-proximafusion
changed the title
Adding hdf option to write vtk data
Adding vtkhdf option to write vtk data
Jan 9, 2025
shimwell
reviewed
Jan 9, 2025
shimwell
reviewed
Jan 9, 2025
shimwell
reviewed
Jan 9, 2025
shimwell
reviewed
Jan 9, 2025
shimwell
reviewed
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #3113 it would be great to have a method of writing VTKHDF files for mesh tally data.
This PR allows users to write .hdf file VTKHDF compatible files with the existing
UnstructuredMesh.write_data_to_vtk()
method. This has a few advantages over the legacy vtk files we currently write.It would be particularly useful for those of us who can't make use of the vtk package in their environment. We have this issue at the moment and can't import cadquery along with openmc due to slightly different vtk packages. It is super useful that vtk is an optional dependency in openmc and not mandated. This use of h5py lets us avoid using the vtk package while still being able to write VTKHDF files
For interested people the VTKHDF roadmap is here, the ability to read these files (ending with hdf) was introduced in Paraview 5.13.0 release notes.
All credit goes to the Kitware developers and particularly @mwestphal who introduced me to this feature
Fixes # (issue)
partly addresses #3113
Checklist