Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nils in words lists better #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marshall-prosperworks
Copy link

Our automated tests use RandomWord to generate test data, but there is a nil in the adjectives list. This causes some small proportion of our tests to fail when exclude? hits the sub-expression word.length on line 61.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 581affb on marshall-prosperworks:remove-null-from-adjectives-list into c6852fe on openlogic:master.

@kinduff
Copy link

kinduff commented Mar 14, 2019

Thanks for this!

@d00rsfan
Copy link

Owner should add to documentation that gem produce a lot of
random_word.rb:61:in excluded?': undefined method length' for nil:NilClass (NoMethodError)
So community will not be waste time with it and move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants