Add missing dependencies #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 29, 2024
|
The LaTeX packages are already part of the default The comment on Hack would be a good addition though. |
|
Probably would be good to document these for ppl who dont want to run it from the dockerfile along with that, no? |
|
In general yes. The problem is that such lists have the tendency to go out of date. So if we do document them, then we should also describe how to update the list. It currently contains 221 packages: |
|
sure sure, understood there's some balance there. so thinking specifically about the use case here, it's ultimately a thin wrapper around pandoc, so it would be nice to be able to run it without needing the full docker container (eg. for proofing papers or creating JOSS-like papers in other contexts). What would it take for that to be the case? If you have a full version of TeX installed it's no problem since you install every package of CTAN by default, but distributions like basictex don't do that, so we need to install some but not all of those packages. Adding those deps to the docker image is a form of passive documentation (that shouldn't affect functionality of the docker image, bc it should just skip installing those since they already are in the base image). IMO it would be nice to have a self-contained template, so we are keeping our internal infra at the same level that we expect of the packages that we review. That would mean making a more formal LaTeX class that uses The things I have added are ones that are directly used in the template:
or are otherwise required. So short of restructuring our templates into CTAN packages (which would probably be a pain) I think adding these deps would be nice, and then when we make changes to the templates that add/remove dependencies we add/remove them from this dockerfile, OR we could add a line in the README like "go to the root docker image and install all these packages" which would be less precise (ie. require more installs than necessary) but wouldn't require changing the docker file here. |
|
That's a good argument. I'm merging this. However, I can't guarantee that this list will stay like this. I think it would be equally, if not more, beneficial to only list the packages that are required on top of those required by pandoc (listed here). But let's use your version for now. |
|
I've cleaned up and documented the list in pandoc/dockerfiles and the list here. Please let me know if there are further improvements that we could make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running from a basictex install, found a number of dependencies that are missed in the dockerfile (i assume they're installed in the base image).
Also added a note to install the hack font, which is done in the docker image but not mentioned in README