Protect against author with no valid roles

openjournals · Sep 18, 2024 · 445500c · 445500c
1 parent 1cc8a6f
commit 445500c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/data/filters/prepare-credit.lua b/data/filters/prepare-credit.lua
@@ -61,7 +61,6 @@ local function prepare_credit (meta)
   meta.hasRoles = false
   for _, author in ipairs(meta.authors or {}) do
     if author.roles then
-      meta.hasRoles = true
       roleList = {}
       for _, roleDict in ipairs(author.roles) do
         roleDict = clean_role_dict(roleDict)
@@ -79,7 +78,10 @@ local function prepare_credit (meta)
           table.insert(roleList, role)
         end
       end
-      author.rolesString = join_with_commas_and(roleList)
+      if #roleList > 0 then
+        meta.hasRoles = true
+        author.rolesString = join_with_commas_and(roleList)
+      end
     end
   end
   return meta

diff --git a/data/templates/default.latex b/data/templates/default.latex
@@ -561,7 +561,9 @@ $if(hasRoles)$
 \section{Author Contributions}\label{author-contributions}
 \begin{enumerate}
 $for(authors)$
+$if(it.rolesString)$
 \item $it.name$ - $it.rolesString$
+$endif$
 $endfor$
 \end{enumerate}
 $endif$

diff --git a/data/templates/preprint.latex b/data/templates/preprint.latex
@@ -442,7 +442,9 @@ $if(hasRoles)$
 \section{Author Contributions}\label{author-contributions}
 \begin{enumerate}
 $for(authors)$
+$if(it.rolesString)$
 \item $it.name$ - $it.rolesString$
+$endif$
 $endfor$
 \end{enumerate}
 $endif$