8345348: CSS Media Queries

[mstr2]

Implementation of CSS media queries.

---

Progress

• Change must not contain extraneous whitespace
• Change requires a CSR request matching fixVersion jfx24 to be approved (needs to be created)
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

• JDK-8345348: CSS Media Queries (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1655/head:pull/1655
$ git checkout pull/1655

Update a local copy of the PR:
$ git checkout pull/1655
$ git pull https://git.openjdk.org/jfx.git pull/1655/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1655

View PR using the GUI difftool:
$ git pr show -t 1655

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1655.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[andy-goryachev-oracle]

is it possible for two different scenes to have different color schemes or any other properties derived from the platform preferences?

would it make more sense to use the platform preferences properties directly?

[mstr2]

I think we need a way for applications to override the OS preferences. Most applications that offer light and dark themes also allow users to switch between them independently from the OS. The advantage of allowing Scene to override those properties is that an application can mix and match light and dark themes (so to answer your question: yes, different scenes can have different color schemes).

This might be useful for stylistic or compatibility reasons. For example, an application might use third-party UI components in tool windows that don't work well with a dark theme (maybe even Swing content), so these windows would use a color scheme that is different from the main window.

[mstr2]

/reviewers 2 reviewer
/csr

[openjdk]

@mstr2
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

[openjdk]

@mstr2 has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@mstr2 please create a CSR request for issue JDK-8345348 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[mlbridge]

Webrevs

• 00: Full (9374122e)