-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8344367: Fix mistakes in FX API docs #1642
base: master
Are you sure you want to change the base?
8344367: Fix mistakes in FX API docs #1642
Conversation
👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into |
@nlisker This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 73 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for fixing these errors (from a guy who contributed at least one)!
I will wait with integration to see what else can be accumulated until the RDPs. |
BTW, did you use IDE for this (and which one)? Eclipse does highlight spelling errors inline when enabled, but I could not find a way to list all of them in the Problems view. |
I found some spellchecker to which you give a URL and it finds the mistakes. I needed it for something else, but then thought it could be used on the JavaDocs so I gave it a shot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The corrections look good to me.
cssref.html L2038: |
A batch of typo and grammar fixes that were found by the spellchecker.
Integration can wait until RDP 1/2.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1642/head:pull/1642
$ git checkout pull/1642
Update a local copy of the PR:
$ git checkout pull/1642
$ git pull https://git.openjdk.org/jfx.git pull/1642/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1642
View PR using the GUI difftool:
$ git pr show -t 1642
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1642.diff
Using Webrev
Link to Webrev Comment