Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8326717: Disable stringop-overflow in shenandoahLock.cpp #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elifaslan1
Copy link

@elifaslan1 elifaslan1 commented Jun 27, 2024

Clean backport to make local fastdebug are working with GCC 13.2.1 on Linux aarch64.
GHA tested.
Tested on linux


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326717 needs maintainer approval

Issue

  • JDK-8326717: Disable stringop-overflow in shenandoahLock.cpp (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/250/head:pull/250
$ git checkout pull/250

Update a local copy of the PR:
$ git checkout pull/250
$ git pull https://git.openjdk.org/jdk22u.git pull/250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 250

View PR using the GUI difftool:
$ git pr show -t 250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/250.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2024

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 27, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport 97aca09e586c086f8130b394682f45724f08b3a4 8326717: Disable stringop-overflow in shenandoahLock.cpp Jun 27, 2024
@openjdk
Copy link

openjdk bot commented Jun 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 27, 2024
@elifaslan1
Copy link
Author

/Approval request Clean backport to make local fastdebug are working with GCC 13.2.1 on Linux aarch64.GHA tested.
Tested on linux

@openjdk openjdk bot added the clean label Jun 27, 2024
@openjdk
Copy link

openjdk bot commented Jun 27, 2024

⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 27, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 27, 2024

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant