You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport JDK-8331931 JFR: Avoid loading regex classes during startup
Validation
Run test make test TEST=jdk/jdk/jfr, all tests passed.
Test results: passed: 592
Report written to /local/home/xlpeng/repos/jdk22u-xlpeng/build/linux-aarch64-server-fastdebug/test-results/jtreg_test_jdk_jdk_jfr/html/report.html
Results written to /local/home/xlpeng/repos/jdk22u-xlpeng/build/linux-aarch64-server-fastdebug/test-support/jtreg_test_jdk_jdk_jfr
Finished running test 'jtreg:test/jdk/jdk/jfr'
Test report is stored in build/linux-aarch64-server-fastdebug/test-results/jtreg_test_jdk_jdk_jfr
==============================
Test summary
==============================
TEST TOTAL PASS FAIL ERROR
jtreg:test/jdk/jdk/jfr 592 592 0 0
==============================
TEST SUCCESS
Finished building target 'test' in configuration 'linux-aarch64-server-fastdebug'
👋 Welcome back pengxiaolong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
⚠️@pengxiaolong This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval request Backport JDK-8331931 JFR: Avoid loading regex classes during startup to jdk22, I have validated the backport by running test jdk/jdk/jfr. Applies cleanly. Overall risk should be low, it's fairly simple change and related tests have passed.
@pengxiaolong This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport JDK-8331931 JFR: Avoid loading regex classes during startup
Validation
Run test
make test TEST=jdk/jdk/jfr
, all tests passed.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/241/head:pull/241
$ git checkout pull/241
Update a local copy of the PR:
$ git checkout pull/241
$ git pull https://git.openjdk.org/jdk22u.git pull/241/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 241
View PR using the GUI difftool:
$ git pr show -t 241
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/241.diff
Webrev
Link to Webrev Comment