Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8322008: Exclude some CDS tests from running with -Xshare:off #235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anantsingh09
Copy link

@anantsingh09 anantsingh09 commented Jun 3, 2024

Reviewed-by: lmesnik, iklam


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322008 needs maintainer approval

Issue

  • JDK-8322008: Exclude some CDS tests from running with -Xshare:off (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/235/head:pull/235
$ git checkout pull/235

Update a local copy of the PR:
$ git checkout pull/235
$ git pull https://git.openjdk.org/jdk22u.git pull/235/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 235

View PR using the GUI difftool:
$ git pr show -t 235

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/235.diff

Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jun 3, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2024

Hi @anantsingh09, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user anantsingh09" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 4d32c607a4b496bf2bb09e54167ecbbab5569a0c 8322008: Exclude some CDS tests from running with -Xshare:off Jun 3, 2024
@openjdk
Copy link

openjdk bot commented Jun 3, 2024

This backport pull request has now been updated with issue from the original commit.

@anantsingh09
Copy link
Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jun 3, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2024

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk openjdk bot removed the approval label Jun 4, 2024
@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Jun 13, 2024
@openjdk
Copy link

openjdk bot commented Jun 13, 2024

⚠️ @anantsingh09 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 13, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 13, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2024

@anantsingh09 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants