Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903754: jcstress should die asap - with report - on broken jvm/hw, instead of waiting on kill #157

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

judovana
Copy link

@judovana judovana commented Jan 5, 2025

Initial PoC

It currently show how to set up argument, and how the framework will be terminated. Feedback welcomed. Should be finished soon


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • CODETOOLS-7903754: jcstress should die asap - with report - on broken jvm/hw, instead of waiting on kill (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/157/head:pull/157
$ git checkout pull/157

Update a local copy of the PR:
$ git checkout pull/157
$ git pull https://git.openjdk.org/jcstress.git pull/157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 157

View PR using the GUI difftool:
$ git pr show -t 157

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/157.diff

Using Webrev

Link to Webrev Comment

@judovana judovana marked this pull request as draft January 5, 2025 15:19
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2025

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@judovana judovana marked this pull request as ready for review January 7, 2025 14:43
@judovana
Copy link
Author

judovana commented Jan 7, 2025

The PR is now moreover done. I will run it through even ore testing through.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 7, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 7, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant