You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this PR is to move properties and properties based initializations to single place, and to document them, and to enable printing the listing with the documentation via help.
No Env. vars were found.
The verbose help can be removed, the individual properties with defaults are wrapped to its class. The OptionSpec and OptionFormatter can be used if needed
Progress
Change must not contain extraneous whitespace
Change must be properly reviewed (1 review required, with at least 1 Committer)
👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
Known properties unifed in one class and printed in verbose help:
The verbose help can be removed, the individual properties with defaults
can be wrapped to its class. Even the OptionSpec and OptionFormatter can
be used if needed
@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
judovana
changed the title
7903889 - Known properties unifed in one class and printed in verbose help
7903889: jcstress: document used properites (and env variables)
Jan 4, 2025
@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
judovana
force-pushed
the
propertiesToHelp
branch
from
The purpose of this PR is to move properties and properties based initializations to single place, and to document them, and to enable printing the listing with the documentation via help.
No Env. vars were found.
The verbose help can be removed, the individual properties with defaults are wrapped to its class. The OptionSpec and OptionFormatter can be used if needed
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/156/head:pull/156$ git checkout pull/156Update a local copy of the PR:
$ git checkout pull/156$ git pull https://git.openjdk.org/jcstress.git pull/156/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 156View PR using the GUI difftool:
$ git pr show -t 156Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/156.diff
Using Webrev
Link to Webrev Comment